[patch] Always open files in binary mode

Rafael EspĂ­ndola rafael.espindola at gmail.com
Mon Feb 24 04:37:17 PST 2014


On 24 February 2014 02:32, NAKAMURA Takumi <geek4civic at gmail.com> wrote:
> I guess it'd be fine, as far as I tested.
> I don't know since when Win32 console was capable of handling \n w/o O_TEXT...
> I wondered CMD.EXE's "TYPE foo.ll" is working with '\n' ...

Good question. I tested on windows 7. Do you have an XP machine available?

> It means we shouldn't use Wide APIs to stdout any more.
> I still wonder how we could handle m17n on win32...
> (In contrast, stderr is left O_TEXT (obey local codepage))

Yes, we never try to change stderr.

Cheers,
Rafael



More information about the llvm-commits mailing list