[llvm] r201937 - Move get[S|U]LEB128Size() to LEB128.h.

Rafael EspĂ­ndola rafael.espindola at gmail.com
Sat Feb 22 06:45:36 PST 2014


> I have changed these functions to inline functions because the existing
> functions in LEB128.h are inline functions.  Besides, these functions are
> small enough to be inlined.  It you have some concern, I can move the
> function definition to lib/Support/LEB128.cpp.

Please do. Until we know they are hot on some use case it is better to
have them out of line.

I also worry about Support growing more functionality that is only
used by a small part of LLVM. How about making this functions in the
llvm namespace, but implementing them in MC?

Cheers,
Rafael



More information about the llvm-commits mailing list