[PATCH] Patch that aligns on bundle size the targets of indirect jumps, and that adds masks before indirect jumps and returns

Sasa Stankovic Sasa.Stankovic at imgtec.com
Fri Feb 21 04:52:30 PST 2014



================
Comment at: lib/Target/Mips/MCTargetDesc/MipsNaClELFStreamer.cpp:36
@@ +35,3 @@
+public:
+  MipsNaClELFStreamer(MCContext &Context, MCAsmBackend &TAB, raw_ostream &OS,
+                      MCCodeEmitter *Emitter)
----------------
Mark Seaborn wrote:
> You didn't reply on my previous comment about this, so I'm not sure if it's necessary, or you just missed the comment?
I actually did reply, but I forgot that I also must click the button at the end of the page.

If I remove it, compiler complains it cannot find constructor for MipsNaClELFStreamer which takes 4 arguments.

================
Comment at: test/MC/Mips/nacl-mask.s:4
@@ +3,3 @@
+# RUN:  | FileCheck %s
+
+# This test tests that address-masking sandboxing is added when given assembly
----------------
Mark Seaborn wrote:
> How about naming this file "nacl-mask-indirect-branches.s", just to make it a bit more descriptive?
I named the file nacl-mask.s because I intended this file to test all masks.


http://llvm-reviews.chandlerc.com/D2847



More information about the llvm-commits mailing list