[PATCH] Move CodeGenPrepare into lib/CodeGen

Hal Finkel hfinkel at anl.gov
Thu Feb 20 10:20:15 PST 2014


----- Original Message -----
> From: "Lang Hames" <lhames at gmail.com>
> To: "Tom Stellard" <tom at stellard.net>
> Cc: "Hal Finkel" <hfinkel at anl.gov>, "Commit Messages and Patches for LLVM" <llvm-commits at cs.uiuc.edu>
> Sent: Thursday, February 20, 2014 12:18:44 PM
> Subject: Re: [PATCH] Move CodeGenPrepare into lib/CodeGen
> 
> Hi All,
> 
> >> I agree, I don't see why we're conflating all of these different
> >> things. Can we not move the pass into CodeGen, and then deal with
> >> adding IR-pass-driving features into llc as a follow-up matter?
> >>
> 
> Absolutely. Sorry - I should have been clearer, but I'm all for this.
> I'm just suggesting that making opt depend on CodeGen should be a
> temporary hack while we teach llc how to run IR -> IR passes neatly.
> Then the CGP tests should be updated to use llc rather than opt.

opt already depends on CodeGen so that it can use TTI, this is necessary to sensibly run the vectorizer, etc. and that seems unlikely to change.

 -Hal

> 
> - Lang.
> 

-- 
Hal Finkel
Assistant Computational Scientist
Leadership Computing Facility
Argonne National Laboratory



More information about the llvm-commits mailing list