[PATCH] Move CodeGenPrepare into lib/CodeGen

[Chandler Carruth]

On Wed, Feb 19, 2014 at 5:56 PM, Chandler Carruth <chandlerc at google.com>wrote:

> CGP is IR to IR pass and I do prefer write unitary test that check against
>> IR =.
>>
>
> We already have a decent number of IR to IR passes in llc. I don't know
> why CGP is special here. I think all of this is a symptom of the fact that
> we haven't actually solved the fundamental problems of target-specific IR
> passes.
>
> If we link lib/CodeGen into the opt tool, we should get rid of llc. It
> looses all value IMO. Instead, I'm suggesting to give it the actual value
> it should have had -- the code generator specific testing, including
> IR-passes that are code generator specific as well as IR -> MI lowering and
> testing at that layer.
>

As it may not have been clear in my prior email, I'm not suggesting that we
*stop* testing CGP as an IR-to-IR pass with FileCheck.

What I'm suggesting is that the hard (but necessary) part of moving CGP to
lib/CodeGen is teaching llc to drive IR-to-IR passes sanely for testing
them in isolation, just like we've enjoyed with opt since ~forever.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140219/dd971259/attachment.html>