[llvm] r201711 - move getNameWithPrefix and getSymbol to TargetMachine.

[Lang Hames]

Hi Rafael,

I was just about to write to apologize for leading you astray with my
suggestion. :)

I think it's best to leave it in TargetMachine for now.

Cheers,
Lang.

On Wed, Feb 19, 2014 at 12:42 PM, Rafael Espíndola
<rafael.espindola at gmail.com> wrote:
> On 19 February 2014 15:30, Rafael Espindola <rafael.espindola at gmail.com> wrote:
>> Author: rafael
>> Date: Wed Feb 19 14:30:41 2014
>> New Revision: 201711
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=201711&view=rev
>> Log:
>> move getNameWithPrefix and getSymbol to TargetMachine.
>>
>> TargetLoweringBase is implemented in CodeGen, so before this patch we had
>> a dependency fom Target to CodeGen. This would show up as a link failure of
>> llvm-stress when building with -DBUILD_SHARED_LIBS=ON.
>>
>> This fixes pr18900.
>
> Hi Lang,
>
> Unfortunately this also effective reverts your suggestion during the
> code review of http://llvm-reviews.chandlerc.com/D2727.  Another file
> that can host the functions in lib/Target is
> TargetLoweringObjectFile.cpp, but for that we would have to keep a
> TargetMachine in TargetLoweringObjectFile. Would you prefer that?
>
> Cheers,
> Rafael