Patch: Extract initialization of TargetOptions from CodeGen flags

[Eli Bendersky]

On Tue, Feb 18, 2014 at 4:21 PM, Nadav Rotem <nrotem at apple.com> wrote:

> LGTM.
>
>
Thanks. r201699.


> On Feb 18, 2014, at 8:54 AM, Eli Bendersky <eliben at google.com> wrote:
>
> Ping!
>
>
> On Thu, Feb 13, 2014 at 10:27 AM, Eli Bendersky <eliben at google.com> wrote:
>
>> The same code (~20 lines) for initializing a TargetOptions object from
>> CodeGen cmdline flags is duplicated 4 (yes 4) times in 4 different tools.
>> This patch moves it into a utility function.
>>
>> Since the CodeGen/CommandFlags.h file defines cl::opt flags *in a
>> header*, it's a bit of a touchy situation because we should only link them
>> into tools. So this patch puts the init function in the header. Ideas for
>> something better are most welcome!
>>
>> PTAL
>> Eli
>>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140219/51cf1ef7/attachment.html>