[PATCH 1/2] Always create unwind table entries for functions marked `uwtable`

[Björn Steinbrink]

On 2014.02.17 08:28:44 -0500, Rafael Espíndola wrote:
> >> With that interpretation, the GCC_except_table should never be
> >> modified based on uwtable.
> >
> > My interpretation of uwtable is based on the change that is reverted in
> > my second patch, the documentation in Attributes.h and the existing
> > method called "needsUnwindTableEntry", which suggests that in fact an
> > entry in the table should be created. If that interpretation is wrong
> > and uwtable should just force CFI to be emitted, then this patch isn't
> > required, there's already code that checks uwtable to do that.
> 
> The UnwindTable in question is for .eh_table, which is what the x86_64
> abi requires for unwinding, both by external tools and for c++
> exceptions.

OK, that clears up a few thing then, I completely mixed up the two
tables. That also caused me two misunderstand Bill's original change. So
my patches are bogus.

> Suggestions for a better name are welcome.

The name is fine for someone who -- unlike me -- actually knows what
"unwind table" means.

Can you recommend some documentation on the matter? The docs I've read
apparently didn't get me to fully understand the topic.

Cheers,
Björn