[PATCH] Use 16 byte stack alignment for NaCl on ARM, and fix a varargs bug

[Mark Seaborn]

On 3 February 2014 14:49, Renato Golin <renato.golin at linaro.org> wrote:

> On 3 February 2014 21:17, Chandler Carruth <chandlerc at google.com> wrote:
>
>> FWIW, if possible it would be good to split this type of change into two
>> patches -- the bug fix, and the change which uncovered it.
>>
>
> Hi Chandler,
>
> I don't think this is necessary. Not only the patch has 2 lines, but it's
> not uncommon for patches implementing a new feature to have the
> corresponding fixes, especially if it's only by introducing the feature
> that the "bug" shows up.
>
> This case is even more obvious, since 8 was the maximum alignment and now
> it's 16. I think you got distracted by Mark's usage of the "bug" word. ;)
>

Right.  Usually I would aim to change just one thing at a time, but in this
case the change to set a larger stack alignment for NaCl is very small.
 I've removed the word "bug" from the description, since I agree it wasn't
really a bug before the change.

Is http://llvm-reviews.chandlerc.com/D2677 OK to commit now?  I believe
I've addressed all the comments.

Cheers,
Mark
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140214/4ee6297d/attachment.html>