[patch] Verify that a GlobalAlias has no section or alignment.

[Rafael Espíndola]

On 12 February 2014 22:23, Reid Kleckner <rnk at google.com> wrote:
> lgtm, assuming this passes an optimized build of something interesting.
>
> Should we go further and assert(!isa<GlobalAlias>(this) || S.empty()); in
> GlobalValue::setSection?

Good point. I can't imagine why some pass would want to set this even
temporarily. We cannot use isa on the header because GlobalAlias is
incomplete there. What do you think of the attached patch? I will try
a clang bootstrap with it tomorrow.

Cheers,
Rafael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: t.patch
Type: text/x-patch
Size: 1880 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140213/34205bf4/attachment.bin>