[llvm] r201194 - DwarfUnit: Replace unnecessary conditionals with asserts.

[Eric Christopher]

Awesome. Thanks.

-eric

On Tue, Feb 11, 2014 at 3:57 PM, David Blaikie <dblaikie at gmail.com> wrote:
> Author: dblaikie
> Date: Tue Feb 11 17:57:03 2014
> New Revision: 201194
>
> URL: http://llvm.org/viewvc/llvm-project?rev=201194&view=rev
> Log:
> DwarfUnit: Replace unnecessary conditionals with asserts.
>
> We used to be pretty vague about what debug entities were what, with
> many conditionals to silently drop/skip/accept things. These don't seem
> to be relevant anymore.
>
> Modified:
>     llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.cpp
>
> Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.cpp?rev=201194&r1=201193&r2=201194&view=diff
> ==============================================================================
> --- llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.cpp (original)
> +++ llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.cpp Tue Feb 11 17:57:03 2014
> @@ -356,9 +356,7 @@ void DwarfUnit::addBlock(DIE *Die, dwarf
>  /// addSourceLine - Add location information to specified debug information
>  /// entry.
>  void DwarfUnit::addSourceLine(DIE *Die, DIVariable V) {
> -  // Verify variable.
> -  if (!V.isVariable())
> -    return;
> +  assert(V.isVariable());
>
>    unsigned Line = V.getLineNumber();
>    if (Line == 0)
> @@ -374,9 +372,7 @@ void DwarfUnit::addSourceLine(DIE *Die,
>  /// addSourceLine - Add location information to specified debug information
>  /// entry.
>  void DwarfUnit::addSourceLine(DIE *Die, DIGlobalVariable G) {
> -  // Verify global variable.
> -  if (!G.isGlobalVariable())
> -    return;
> +  assert(G.isGlobalVariable());
>
>    unsigned Line = G.getLineNumber();
>    if (Line == 0)
> @@ -391,9 +387,7 @@ void DwarfUnit::addSourceLine(DIE *Die,
>  /// addSourceLine - Add location information to specified debug information
>  /// entry.
>  void DwarfUnit::addSourceLine(DIE *Die, DISubprogram SP) {
> -  // Verify subprogram.
> -  if (!SP.isSubprogram())
> -    return;
> +  assert(SP.isSubprogram());
>
>    // If the line number is 0, don't add it.
>    unsigned Line = SP.getLineNumber();
> @@ -410,9 +404,7 @@ void DwarfUnit::addSourceLine(DIE *Die,
>  /// addSourceLine - Add location information to specified debug information
>  /// entry.
>  void DwarfUnit::addSourceLine(DIE *Die, DIType Ty) {
> -  // Verify type.
> -  if (!Ty.isType())
> -    return;
> +  assert(Ty.isType());
>
>    unsigned Line = Ty.getLineNumber();
>    if (Line == 0)
> @@ -427,9 +419,7 @@ void DwarfUnit::addSourceLine(DIE *Die,
>  /// addSourceLine - Add location information to specified debug information
>  /// entry.
>  void DwarfUnit::addSourceLine(DIE *Die, DIObjCProperty Ty) {
> -  // Verify type.
> -  if (!Ty.isObjCProperty())
> -    return;
> +  assert(Ty.isObjCProperty());
>
>    unsigned Line = Ty.getLineNumber();
>    if (Line == 0)
> @@ -445,9 +435,7 @@ void DwarfUnit::addSourceLine(DIE *Die,
>  /// addSourceLine - Add location information to specified debug information
>  /// entry.
>  void DwarfUnit::addSourceLine(DIE *Die, DINameSpace NS) {
> -  // Verify namespace.
> -  if (!NS.Verify())
> -    return;
> +  assert(NS.Verify());
>
>    unsigned Line = NS.getLineNumber();
>    if (Line == 0)
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits