[PATCH] Fix a mingw32 build issue

Aaron Ballman aaron at aaronballman.com
Wed Feb 12 08:29:38 PST 2014


On Wed, Feb 12, 2014 at 4:59 AM, NAKAMURA Takumi <geek4civic at gmail.com> wrote:
> Agreed. I have disliked it. Michael, shall we rename it like "Support-win32.h" ?
>
> 2014-02-12 18:54 GMT+09:00 Yaron Keren <yaron.keren at gmail.com>:
>> I see now, LLVM has its own Windows.h.  That's confusing, LLVM should not
>> use standard header file names. This file should be "Windows-LLVM.h" or
>> something else unique.

I agree; naming it Windows.h was confusing at best. I am okay with
Windows-LLVM.h, but would also be okay with Win32.h, or
Win32Support.h.

~Aaron



More information about the llvm-commits mailing list