[llvm] r201110 - Fix an old FIXME. LDPO_PIE is available since 2.23, realeased 2012-10-22.

[İsmail Dönmez]

Hi,


On Tue, Feb 11, 2014 at 7:07 PM, Sylvestre Ledru <sylvestre at debian.org>wrote:
>
> Do you mind if I apply this patch:
> Index: tools/gold/gold-plugin.cpp
> ===================================================================
> --- tools/gold/gold-plugin.cpp    (révision 201158)
> +++ tools/gold/gold-plugin.cpp    (copie de travail)
> @@ -153,7 +153,11 @@
>          switch (tv->tv_u.tv_val) {
>            case LDPO_REL:  // .o
>            case LDPO_DYN:  // .so
> +#ifdef LDPO_PIE
>            case LDPO_PIE:  // position independent executable
> +#else
> +            case 3:
> +#endif
>              output_type = LTO_CODEGEN_PIC_MODEL_DYNAMIC;
>              break;
>            case LDPO_EXEC:  // .exe
>

Why not;

#ifndef LDPO_PIE
#define LDPO_PIE 3
#endif

Its cleaner this way.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140211/358436fd/attachment.html>