[llvm] r200767 - Implemented support for Process::GetRandomNumber on Windows.

Aaron Ballman aaron at aaronballman.com
Tue Feb 11 09:17:14 PST 2014


On Tue, Feb 11, 2014 at 12:12 PM, Stephan Tolksdorf <st at quanttec.com> wrote:
> Sorry for not seeing this thread earlier. I've got to fix my email
> configuration...
>
> Aaron, thanks a lot for jumping and helping out!

No worries!

> As I wrote in my original patch email: I had tested the patch with (multiple
> versions) mingw-w64, and libc++ uses the function in the same way.
>
> One tricky aspect of rand_s is that you have to make sure that _CRT_RAND_S
> is defined before stdlib.h is included the first time.
>
> What versions of MinGW are LLVM, Clang and libc++ actually trying to
> support?

Galina can probably tell us what version her bot is using, but
honestly, the fact that we have a bot testing that configuration is
enough for me. I don't think this function warrants upgrading or
dropping the bot.

~Aaron



More information about the llvm-commits mailing list