[PATCH] Use an 'l' prefix when an 'L' prefix would produce an invalid MachO

Lang Hames lhames at gmail.com
Mon Feb 10 22:42:24 PST 2014


  Hi Rafael,

  Thanks very much for working on this.

  One thing I wanted to ask about: I always think of TargetMachine as an interface for accessing other Target specific information, rather than a utility in its own right. Would the getSymbol and getNameWithPrefix operations make more sense on TargetLoweringBase instead?

  I've attached a patch to this comment that moves those methods there. I'm new to phabricator, so apologies if there's a better way to attach this thing. I didn't see any UI option for 'attach alternate patch'.

  - Lang.

http://llvm-reviews.chandlerc.com/D2727



More information about the llvm-commits mailing list