[llvm] r201057 - Remove shell comment in the middle of a single-line command.

NAKAMURA Takumi geek4civic at gmail.com
Sun Feb 9 15:18:00 PST 2014


Thanks, Bob, ... I didn't reproduce failure locally.

2014-02-10 7:36 GMT+09:00 Bob Wilson <bob.wilson at apple.com>:
> Author: bwilson
> Date: Sun Feb  9 16:36:31 2014
> New Revision: 201057
>
> URL: http://llvm.org/viewvc/llvm-project?rev=201057&view=rev
> Log:
> Remove shell comment in the middle of a single-line command.
>
> You can't put a comment in the middle of a command like this. This is
> invalid shell syntax and breaks the build.
>
> Modified:
>     llvm/trunk/cmake/modules/Makefile
>
> Modified: llvm/trunk/cmake/modules/Makefile
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/cmake/modules/Makefile?rev=201057&r1=201056&r2=201057&view=diff
> ==============================================================================
> --- llvm/trunk/cmake/modules/Makefile (original)
> +++ llvm/trunk/cmake/modules/Makefile Sun Feb  9 16:36:31 2014
> @@ -53,8 +53,6 @@ $(PROJ_OBJ_DIR)/LLVMConfig.cmake: LLVMCo
>           -e 's/@LLVM_CONFIG_EXPORTS_FILE@/$${LLVM_CMAKE_DIR}\/LLVMExports.cmake/' \
>           -e 's/@all_llvm_lib_deps@//' \
>          && \
> -        # TODO: Teach LLVM-Config.cmake to use builtin CMake features     \
> -        # for library dependencies.  For now add the generated fragments. \
>          grep '^set_property.*LLVMBUILD_LIB_DEPS_' "$(LLVMBuildCMakeFrag)" \
>         ) > $@
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits



More information about the llvm-commits mailing list