[PATCH] AAPCS-VFP: Do not use any more VFP registers after allocating a CPRC to the stack

Renato Golin renato.golin at linaro.org
Fri Feb 7 02:18:46 PST 2014


On 7 February 2014 10:08, James Molloy <james.molloy at arm.com> wrote:

> The first line did shadow just R3 but now shadows all registers. I suspect
> that actually this was a bug, which you have now fixed incidentally? Your
> patch description only mentions coprocessor registers so can you just
> confirm this is deliberate?
>
>
>
> The second line has changed behaviour - previously in the i32 case no
> registers were shadowed - now R0-R3 are shadowed. Why is this correct? (not
> saying it's not, but some justification would be good).
>

I assumed both cases were the same "fix" that weren't mentioned in the
commit message (and that's why I was unsure of the "fix").

If that's correct, I agree would be good to have a mention in the commit
message. ;)

cheers,
--renato
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140207/2c2892a7/attachment.html>


More information about the llvm-commits mailing list