[llvm] r200886 - Inliner uses a smaller inline threshold for callees with cold attribute.

[Chandler Carruth]

On Wed, Feb 5, 2014 at 2:53 PM, Manman Ren <manman.ren at gmail.com> wrote:

> Author: mren
> Date: Wed Feb  5 16:53:44 2014
> New Revision: 200886
>
> URL: http://llvm.org/viewvc/llvm-project?rev=200886&view=rev
> Log:
> Inliner uses a smaller inline threshold for callees with cold attribute.
>
> Added command line option inlinecold-threshold to set threshold for
> inlining
> functions with cold attribute. Listen to the cold attribute when it would
> decrease the inline threshold.
>

You've not gotten any discussion about this or presented any benchmark
numbers for this what-so-ever.

The cold attribute is widely used already and this may have a very dramatic
impact. I don't think it is really acceptable to just land a patch that
could have such a far reaching impact without even a decent discussion or
some benchmark numbers to ensure this doesn't regress things.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140205/f9edd6db/attachment.html>