[PATCH] [sanitizer] Implement ioctl decoding.

Evgeniy Stepanov eugenis at google.com
Wed Feb 5 11:25:52 PST 2014


OK. It would be nice to enable these checks on Mac later. Please change the
comment into a FIXME and commit.
On Feb 5, 2014 11:16 PM, "Sergey Matveev" <earthdok at google.com> wrote:

>
>
> ================
> Comment at: lib/sanitizer_common/sanitizer_platform_limits_posix.cc:790
> @@ -789,1 +789,3 @@
>
> +// We define those on Linux and Mac, but only check on Linux.
> +COMPILER_CHECK(IOC_NRBITS == _IOC_NRBITS);
> ----------------
> Evgeniy Stepanov wrote:
> > Why? Missing headers?
> I'm not sure if they're there or not. The pre-existing check was under an
> #ifdef LINUX. I just documented this state of affairs explicitly.
>
> Also the EVIOC stuff seems to be Linux-specific.
>
>
> http://llvm-reviews.chandlerc.com/D2689
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140205/a30d1438/attachment.html>


More information about the llvm-commits mailing list