[llvm] r200688 - Introduce SmallPtrSetImpl<T *> which allows insert, erase, count, and

Justin Bogner mail at justinbogner.com
Tue Feb 4 15:33:58 PST 2014


Chandler Carruth <chandlerc at gmail.com> writes:
> Introduce SmallPtrSetImpl<T *> which allows insert, erase, count, and
> iteration. This alows the majority of operations to be performed without
> encoding a specific small size. It follows the model of
> SmallVectorImpl<T>.

There's a lot to be said for following the existing practice, so feel
free to ignore this, but SmallVectorImpl isn't really a very indicative
name for how it's used in the first place. It's just ubiquitous enough
that it isn't worth changing. Maybe a better name from the get-go for
SmallPtrSetImpl would be worthwhile?

On the other hand, it probably isn't worth bikeshedding about a perfect
name for this.



More information about the llvm-commits mailing list