[PATCH] ARM: Resolve thumb_bl fixup in same MCFragment.

David Peixotto dpeixott at codeaurora.org
Tue Feb 4 08:56:48 PST 2014


  Just noticed something I missed before. Might not be necessary, but please take a look.


================
Comment at: lib/Target/ARM/MCTargetDesc/ARMAsmBackend.cpp:579
@@ -570,4 +578,3 @@
   // symbol's thumb-ness to get interworking right.
   if (A && ((unsigned)Fixup.getKind() == ARM::fixup_arm_thumb_blx ||
             (unsigned)Fixup.getKind() == ARM::fixup_arm_blx ||
----------------
Wouldn't we need to still fall through here if the target symbol is not in the same fragment?


http://llvm-reviews.chandlerc.com/D2675

BRANCH
  fix-thumb-far-jump

ARCANIST PROJECT
  llvm



More information about the llvm-commits mailing list