[llvm] r200737 - Revert: ARM: Enable use of relocation type tlsldo in debug info for tls data.

Kai Nacke kai.nacke at redstar.de
Mon Feb 3 22:07:00 PST 2014


Author: redstar
Date: Tue Feb  4 00:07:00 2014
New Revision: 200737

URL: http://llvm.org/viewvc/llvm-project?rev=200737&view=rev
Log:
Revert: ARM: Enable use of relocation type tlsldo in debug info for tls data.

There seems to be a new problem with the debug info in the test case.
I'll have to investigate this.

Removed:
    llvm/trunk/test/DebugInfo/ARM/tls.ll
Modified:
    llvm/trunk/lib/Target/ARM/ARMTargetObjectFile.cpp
    llvm/trunk/lib/Target/ARM/ARMTargetObjectFile.h

Modified: llvm/trunk/lib/Target/ARM/ARMTargetObjectFile.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/ARMTargetObjectFile.cpp?rev=200737&r1=200736&r2=200737&view=diff
==============================================================================
--- llvm/trunk/lib/Target/ARM/ARMTargetObjectFile.cpp (original)
+++ llvm/trunk/lib/Target/ARM/ARMTargetObjectFile.cpp Tue Feb  4 00:07:00 2014
@@ -51,9 +51,3 @@ getTTypeGlobalReference(const GlobalValu
                                  MCSymbolRefExpr::VK_ARM_TARGET2,
                                  getContext());
 }
-
-const MCExpr *ARMElfTargetObjectFile::
-getDebugThreadLocalSymbol(const MCSymbol *Sym) const {
-  return MCSymbolRefExpr::Create(Sym, MCSymbolRefExpr::VK_ARM_TLSLDO,
-                                 getContext());
-}

Modified: llvm/trunk/lib/Target/ARM/ARMTargetObjectFile.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/ARMTargetObjectFile.h?rev=200737&r1=200736&r2=200737&view=diff
==============================================================================
--- llvm/trunk/lib/Target/ARM/ARMTargetObjectFile.h (original)
+++ llvm/trunk/lib/Target/ARM/ARMTargetObjectFile.h Tue Feb  4 00:07:00 2014
@@ -36,9 +36,6 @@ public:
   virtual const MCSection *getAttributesSection() const {
     return AttributesSection;
   }
-
-  /// \brief Describe a TLS variable address within debug info.
-  virtual const MCExpr *getDebugThreadLocalSymbol(const MCSymbol *Sym) const;
 };
 
 } // end namespace llvm

Removed: llvm/trunk/test/DebugInfo/ARM/tls.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/ARM/tls.ll?rev=200736&view=auto
==============================================================================
--- llvm/trunk/test/DebugInfo/ARM/tls.ll (original)
+++ llvm/trunk/test/DebugInfo/ARM/tls.ll (removed)
@@ -1,26 +0,0 @@
-; RUN: llc -O0 -filetype=asm -mtriple=armv7-linux-gnuehabi < %s | FileCheck %s
-;
-; Generated with clang with source
-; __thread int x;
-
- at x = thread_local global i32 0, align 4
-
-!llvm.dbg.cu = !{!0}
-!llvm.module.flags = !{!7, !8}
-
-; 6 byte of data
-; CHECK: .byte 6 @ DW_AT_location
-; DW_OP_const4u
-; CHECK: .byte 12
-; The debug relocation of the address of the tls variable
-; CHECK: .long x(tlsldo)
-
-!0 = metadata !{i32 786449, metadata !1, i32 12, metadata !"clang version 3.5 ", i1 false, metadata !"", i32 0, metadata !2, metadata !2, metadata !2, metadata !3, metadata !2, metadata !""} ; [ DW_TAG_compile_unit ] [/tmp/arm.c] [DW_LANG_C99]
-!1 = metadata !{metadata !"arm.c", metadata !"/tmp"}
-!2 = metadata !{i32 0}
-!3 = metadata !{metadata !4}
-!4 = metadata !{i32 786484, i32 0, null, metadata !"x", metadata !"x", metadata !"", metadata !5, i32 1, metadata !6, i32 0, i32 1, i32* @x, null} ; [ DW_TAG_variable ] [x] [line 1] [def]
-!5 = metadata !{i32 786473, metadata !1}          ; [ DW_TAG_file_type ] [/tmp/arm.c]
-!6 = metadata !{i32 786468, null, null, metadata !"int", i32 0, i64 32, i64 32, i64 0, i32 0, i32 5} ; [ DW_TAG_base_type ] [int] [line 0, size 32, align 32, offset 0, enc DW_ATE_signed]
-!7 = metadata !{i32 2, metadata !"Dwarf Version", i32 4}
-!8 = metadata !{i32 1, metadata !"Debug Info Version", i32 1}





More information about the llvm-commits mailing list