[Mesa-dev] [PATCH] R600/SI: Fix fneg for 0.0

Michel Dänzer michel at daenzer.net
Mon Feb 3 20:19:11 PST 2014


On Mon, 2014-02-03 at 14:16 -0800, Tom Stellard wrote:
> 
> It's clear that there a few things that are wrong which are unrelated to this
> patch, so I think it is fine as is.  Could you add a comment above the pattern
> explaining why we need to manually toggle the sign bit and also a todo to fix FabsFree
> and FNegFree.

Comments added in v3.


> If you add a lit test, then this patch has my r-b.

The v2 patch updates the two existing lit tests and adds a third one. Do
you have any other additional lit test(s) in mind?


-- 
Earthling Michel Dänzer            |                  http://www.amd.com
Libre software enthusiast          |                Mesa and X developer




More information about the llvm-commits mailing list