[PATCH] Use 16 byte stack alignment for NaCl on ARM, and fix a varargs bug

Chandler Carruth chandlerc at google.com
Mon Feb 3 13:17:42 PST 2014


On Mon, Feb 3, 2014 at 12:50 PM, Mark Seaborn <mseaborn at chromium.org> wrote:

> Hi sdyatkovskiy,
>
> Use 16 byte stack alignment for NaCl on ARM, and fix a varargs bug
>
> NaCl's ARM ABI uses 16 byte stack alignment.
>
> Using this alignment exposes a bug in code generation in which a
> varargs function leaves a 4 byte gap between the values of r1-r3 saved
> to the stack and the following arguments that were passed on the
> stack.
>

FWIW, if possible it would be good to split this type of change into two
patches -- the bug fix, and the change which uncovered it.

Not that I know anything about ARM NaCl ABI. =]
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140203/f2e99033/attachment.html>


More information about the llvm-commits mailing list