[PATCH] Subclass DynamicTable for each targets to factor out handling of target dependent part of a dynamic table

[Shankar Easwaram]

LGTM

Sent from my iPhone

> On Jan 30, 2014, at 23:30, Rui Ueyama <ruiu at google.com> wrote:
> 
> It's also worth noting that the current patch is *by far* better than the original patch. The current patch is only 10 line long, while the original one would add more than 500 lines of code.
> 
> 
>> On Thu, Jan 30, 2014 at 9:22 PM, Simon Atanasyan <simon at atanasyan.com> wrote:
>> 
>>   This time I know the only target needs to override the only dynamic table tag. It is MIPS. Maybe there are other targets with the same requirements but AFAIK x86, x86_64, arm, ppc, hexagon etc do not need such "translation". If we make a complicated design right now we might never get any benefits from it. Moreover we try to invent a complicated design without proper specification. Who know maybe there is an architecture which combines content of two "standard" tags into the single "non-standard" one? Should we support such hypothetical requirements? From the other side, if or when a number of methods like proposed `getGotPltTag()` grow in the future and or we get know about other "non-standard" targets, we will be able to estimate new demands and replace the current simple design.
>> 
>> http://llvm-reviews.chandlerc.com/D2643
> 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140131/06bbd037/attachment.html>