[PATCH] Subclass DynamicTable for each targets to factor out handling of target dependent part of a dynamic table

[Rui Ueyama]

On Thu, Jan 30, 2014 at 8:34 PM, Shankar Easwaram <shankarke at gmail.com>wrote:

> Whatever tags you want each architecture to override needs to have some
> sort of mapping so that architectures can override things in whichever way
> they want.
>
> Thoughts ?
>

Really need such abstraction for this three line patch (without comments)?
I think it's overdesigning, as it wouldn't make code easier to understand
but rather hard to read. What we want to do seems to use a different tag
only in MIPS for .got.plt section, which is exactly what Simon's patch does.

Sent from my iPhone
>
> > On Jan 30, 2014, at 14:17, Simon Atanasyan <simon at atanasyan.com> wrote:
> >
> >
> >  What do you mean by "mappings that translate from one tag to another"?
> Maybe I misunderstand you but the translation functionality seems to be a
> bit complicated for just a couple of tags.
> >
> > http://llvm-reviews.chandlerc.com/D2643
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140130/a1dce4f4/attachment.html>