[llvm] r200503 - DAGCombine should not produce ISD::OR nodes after operation legalization if they're not legal.

[Owen Anderson]

On Jan 30, 2014, at 5:07 PM, David Blaikie <dblaikie at gmail.com> wrote:

> 
> 
> 
> On Thu, Jan 30, 2014 at 5:02 PM, Owen Anderson <resistor at mac.com> wrote:
> 
> On Jan 30, 2014, at 5:01 PM, David Blaikie <dblaikie at gmail.com> wrote:
> 
>> 
>> 
>> 
>> On Thu, Jan 30, 2014 at 4:51 PM, Owen Anderson <resistor at mac.com> wrote:
>> Author: resistor
>> Date: Thu Jan 30 18:51:43 2014
>> New Revision: 200503
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=200503&view=rev
>> Log:
>> DAGCombine should not produce ISD::OR nodes after operation legalization if they're not legal.
>> 
>> Is this not testable for some reason?
> 
> No in-tree targets, to my knowledge, have a legal ISD::ADD but an illegal ISD::OR.
> 
> Figured - and though it's a big ask (& not an immediate issue, just out of general curiosity) I don't suppose there's any chance of unit testing this sort of thing?

Nope.

> (and/or perhaps some artificial target we can just bundle in a bunch of quirky features like this to test)

Possible?  Yes.  Practical?  Not really.  You’d end up needing a new artificial target to illustrate each particular combination of quirks, since many of them are mutually exclusive.

—Owen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140130/969c425b/attachment.html>