[PATCH] [sanitizer] Add most ioctls from /usr/include/sound/.

Sergey Matveev earthdok at google.com
Thu Jan 30 11:24:25 PST 2014


  > to see that there is no systematic error here

  Would you consider the fact that this fixed my content_unittests crashes to be sufficient verification? (Obviously for regression testing one test would do nothing).


================
Comment at: lib/sanitizer_common/sanitizer_common_interceptors_ioctl.inc:663
@@ -534,3 +662,3 @@
                              unsigned request, void *arg) {
   if (desc->type == ioctl_desc::READ) {
     unsigned size = desc->size ? desc->size : IOC_SIZE(request);
----------------
Evgeniy Stepanov wrote:
> Why not add READWRITE here in the same commit?
fixed


http://llvm-reviews.chandlerc.com/D2659

BRANCH
  msan/ioctl_alsa

ARCANIST PROJECT
  compiler-rt



More information about the llvm-commits mailing list