[PATCH] Fix PR18381 - print a minimal diagnostic rather than assert on unresolved .secidx target

[Jim Grosbach]

That subtraction diagnostic doesn’t generate a stack trace, does it? I don’t see one on Darwin, anyway. Perhaps a platform difference?

The top level report_fatal_error() function has a parameter for whether to consider the failure a crasher or not, but doesn’t look like this is going through that path.

-Jim

On Jan 30, 2014, at 10:54 AM, Reid Kleckner <rnk at google.com> wrote:

> I'd leave the stack trace alone for now.  That's what all other MC errors do.  If somebody wants to fix that, they can do it later.
> 
> For the wording, IMO it'd be more consistent to say that this was an "undefined symbol".  It's not clear what "couldn't resolve" means, and "undefined" feels more precise.  Also, we should mention .secidx.
> 
> We have other errors like:
>           Twine("symbol '") + B->getName() +
>               "' can not be undefined in a subtraction expression");
> 
> So we could do something like:
> Cannot get section of undefined symbol 'bar' in .secidx directive
> 
> 
> On Thu, Jan 30, 2014 at 10:46 AM, Timur Iskhodzhanov <timurrrr at google.com> wrote:
> What's the recommended way to get rid of the stacktrace?
> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140130/ffc02b11/attachment.html>