[PATCH] Silence warning by commenting unused macro in GTest

Renato Golin renato.golin at linaro.org
Thu Jan 30 11:01:46 PST 2014


Thanks, done in r200479.


On 30 January 2014 18:49, Alp Toker <alp at nuanti.com> wrote:

>
> On 30/01/2014 18:42, Renato Golin wrote:
>
>> Modern compilers (Clang 3.4, GCC 4.8) warn on variadic macros being
>> introduced in C99, which produces a huge number of useless diagnostics
>> since this macro is unused in the whole project.
>>
>> All tests compile and pass.
>>
>
> In the comment just go for "// Disabled to silence LLVM build warnings."
> to point out it's a local change. The versions are fuzzy anyway so not much
> value in listing them.
>
> Also can you disable the code with #if 0 instead of a comment?
>
> Otherwise looks fine as a way of silencing the noise, thanks
>
> Alp.
>
> --
> http://www.nuanti.com
> the browser experts
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140130/50a3f758/attachment.html>


More information about the llvm-commits mailing list