[PATCH] Silence warning by commenting unused macro in GTest

Alp Toker alp at nuanti.com
Thu Jan 30 10:49:52 PST 2014


On 30/01/2014 18:42, Renato Golin wrote:
> Modern compilers (Clang 3.4, GCC 4.8) warn on variadic macros being
> introduced in C99, which produces a huge number of useless diagnostics
> since this macro is unused in the whole project.
>
> All tests compile and pass.

In the comment just go for "// Disabled to silence LLVM build warnings." 
to point out it's a local change. The versions are fuzzy anyway so not 
much value in listing them.

Also can you disable the code with #if 0 instead of a comment?

Otherwise looks fine as a way of silencing the noise, thanks

Alp.

-- 
http://www.nuanti.com
the browser experts




More information about the llvm-commits mailing list