[PATCH] [RFC] Rewrite the way we generate debug locations for variables.

David Blaikie dblaikie at gmail.com
Thu Jan 30 08:28:56 PST 2014


Quick gut-reaction: that class is big enough that it deserves its own file.
(I realize you're just looking for a sanity check of the approach - and
I'll try to express some opinion on that too, though I don't think I'm
fully qualified to be the arbiter for this increased (though probably
justified) complexity - I don't have nearly enough knowledge about the
backend, location information, and other ways to approach this problem -
I'll try to ask around)

- David


On Thu, Jan 30, 2014 at 8:21 AM, Alexey Samsonov <samsonov at google.com>wrote:

>   clang-formatize the new code
>
> Hi dblaikie,
>
> http://llvm-reviews.chandlerc.com/D2658
>
> CHANGE SINCE LAST DIFF
>   http://llvm-reviews.chandlerc.com/D2658?vs=6773&id=6774#toc
>
> Files:
>   lib/CodeGen/AsmPrinter/DwarfDebug.cpp
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140130/22c73fac/attachment.html>


More information about the llvm-commits mailing list