[PATCH] [RFC] Compiler-RT on ARM via CMake

[Renato Golin]

On 30 January 2014 12:49, Alexey Samsonov <samsonov at google.com> wrote:

> Did you actually upload the new version? I don't see it in Phab.
>

No, I'm still playing with the options, and the main change is in Clang, so
not relevant to this RT phab review. Attached is the Clang patch.


  The message about detect_leaks is irrelevant here, it's just a warning.
> However, we should probably turn on leak checking in ASan unit tests only
> on supported platforms to reduce noise. See
> compiler-rt/lib/asan/lit_tests/Unit/lit.site.cfg.in. However, you may not
> bother about it at the moment.
>

Right, I'll try and disable just the leak check, something like:

if config.host_os == 'Linux' and config.arch == 'x86_64':
  config.environment['ASAN_OPTIONS'] = 'detect_leaks=1'

Right now, I'm building the whole thing, will take a while.

I found it hard to build just the unit tests. Even if I delete the test
binary, or the objects, and "make check-asan", it doesn't rebuild the unit
test (but it does run it). Maybe something wrong with the cmake files?


  Can you invoke the test cases directly (run the unit test binary with
> specifying --gtest_filter=AddressSanitizer.ThreadedMallocStressTest) and
> see what the problem is? These tests have substantial memory requirements,
> so maybe there's just not enough RAM on your machine. I think we have
> ASAN_LOW_MEMORY in ASan runtime compile definition for that.
>

I noticed that they segfault right after printing the message, so the
message is probably a red herring. I will run them in debug mode.

cheers,
--renato
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140130/5a875010/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: clang.patch
Type: text/x-patch
Size: 2131 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140130/5a875010/attachment.bin>