[llvm] r199886 - Prevent repetitive warnings for unrecognized processors and features

Artyom Skrobov Artyom.Skrobov at arm.com
Wed Jan 29 12:24:46 PST 2014


>> If the documentation doesn't guide around these larger architectural
issues,
>> and the existing code cannot be trusted as an example to follow, then the
>> only remaining option I can see is to submit patches at random, until one
of
>> them gets accepted.
>
> My naive question would be: what's unique about this argument handling
that
> leads to duplicate error messages here but not for any other argument
> handling?

That's indeed a promising approach -- instead of suppressing the warnings on
repeated lookup failures, to prevent the repeated lookups in the first
place.

I'm currently preparing a new patch, with an extensive refactoring of
MCSubtargetInfo and SubtargetFeatures, to prevent the repeated lookups of
CPU entries. For the feature lookup failures, I would still use a set of
strings to mark the features whose lookup failed; but this set will be local
to the MCSubtargetInfo instance.

Thank you for your suggestion to investigate the cause of the repeated
lookup failures.







More information about the llvm-commits mailing list