[PATCH] Add support for assigning to . in AsmParser

Jim Grosbach grosbach at apple.com
Tue Jan 28 16:08:52 PST 2014



================
Comment at: lib/MC/MCParser/AsmParser.cpp:2128
@@ +2127,3 @@
+    if (Out.EmitValueToOffset(Value, 0)) {
+      Error(EqualLoc, "expected assembly-time absolute expression in assignment to pseudo-symbol '.'");
+      eatToEndOfStatement();
----------------
Other diagnostics for this sort of thing just say "expected absolute expression". Does the additional verbiage here communicate enough useful additional information to be worth diverging?


http://llvm-reviews.chandlerc.com/D2625



More information about the llvm-commits mailing list