[llvm] r200351 - Tests for mode switching

[David Woodhouse]

On Tue, 2014-01-28 at 18:52 -0500, Rafael Espíndola wrote:
> > @@ -0,0 +1,23 @@
> > +; RUN: llc < %s -mtriple thumbv7-linux -filetype=obj -o %t
> > +; Two pass decoding needed because llvm-objdump does not respect mapping symbols
> > +; RUN: llvm-objdump -triple thumbv7-linux -d %t | FileCheck --check-prefix=THUMB %s
> > +; RUN: llvm-objdump -triple armv7-linux   -d %t | FileCheck --check-prefix=ARM   %s

> Why do you need to use "llc -filetype=obj" in here? There is nothing
> special about the handling of inline asm that I could see in the code
> path. You should be able to test that the relaxations are correct by
> running "llc ... | llvm-mc -filetype=obj", no?

I suppose so. And in fact there's not much interesting to test on the
llc side either; the interesting part is what llvm-mc is doing. And we
are testing *that* in test/MC/ARM/fixup-cpu-mode.s already.

So perhaps this whole test is completely redundant?

David, would you object to removing it completely? Or would you prefer
to keep it and modify it as Rafael requests? 

-- 
dwmw2

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 5745 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140128/dbfb8e77/attachment.bin>