[PATCHES] PR18303: Use appropriate Feature flags for encoding instructions

[David Peixotto]

> >> Updated again at http://git.infradead.org/users/dwmw2/llvm.git —
> >> after all, I was responsible for a reasonable proportion of the
> >> breakage when you try to apply it to today's tree, since I've been
> >> messing with the
> >> X86 target.
> >
> > Wow, thanks for that! I'm afraid we could be stuck in this rebasing
> > loop for a while unless we can build consensus that this is the
> > approach we want to take and get it committed. I'm not really sure how
> > to make that happen.
> 
> I concede I'm still finding my way here and calibrating how much I can get
> away with... but I think recall any dissent. I think we *do* have
> sufficient consensus and if we just fixed the uniquification of the STI --
> or showed that the memory usage wasn't a serious concern in practice so it
> could reasonably be left as a later optimisation -- I'd be happy with
> committing it and waiting to see who shouts at me for it :)

If you want to take up the mantle and get the patches committed you have my support :) They really represent your work and insight anyway... I just followed it to the logical conclusion suggested by Jim.

I agree with you that I do not recall any dissent. You could try uploading to phabricator to get someone to give it a +1. It seems to be a good way to get eyes on the larger patches. I've also seen that people tend to do more post-commit reviews as well, so as you said, you could try committing and waiting for that feedback.