[PATCH] MC: Better management of macro arguments

David Majnemer david.majnemer at gmail.com
Tue Jan 28 10:36:52 PST 2014


  No problem, I will make @rafael's commits.


================
Comment at: lib/MC/MCParser/AsmParser.cpp:1886
@@ -1874,4 +1885,3 @@
   for (;;) {
     if (Lexer.is(AsmToken::Eof) || Lexer.is(AsmToken::Equal)) {
       return TokError("unexpected token in macro instantiation");
----------------
Rafael Ávila de Espíndola wrote:
> You can now remove the {.
> 
Agreed.  I felt like that could be done in a later commit for VCS cleanliness.

================
Comment at: test/MC/AsmParser/darwin_macros.s:47
@@ -46,3 +47,1 @@
 
-.macro test5 _a
-.globl "\_a"
----------------
Rafael Ávila de Espíndola wrote:
> Why this change? Are named arguments not supported on darwin?
According to my own tests and the [[https://developer.apple.com/library/mac/documentation/DeveloperTools/Reference/Assembler/Assembler.pdf|Darwin Assembler documentation]], no.


http://llvm-reviews.chandlerc.com/D2634



More information about the llvm-commits mailing list