[PATCH] Fix PR18345: ldr= pseudo instruction produces incorrect code when using in inline assembly

David Peixotto dpeixott at codeaurora.org
Tue Jan 28 09:58:42 PST 2014



================
Comment at: lib/Target/ARM/MCTargetDesc/ARMTargetStreamer.cpp:177
@@ +176,3 @@
+//
+ARMTargetMachOStreamer::ARMTargetMachOStreamer(MCStreamer &S)
+    : ARMTargetStreamer(S) {}
----------------
Saleem Abdulrasool wrote:
> Would you mind splitting out ARMTargetMachOStreamer into a separate file?
Sure, no problem. Will upload an updated patch.

================
Comment at: lib/Target/ARM/MCTargetDesc/ARMELFStreamer.cpp:108
@@ -107,3 @@
-void ARMTargetStreamer::anchor() {}
-ARMTargetStreamer::ARMTargetStreamer(MCStreamer &S) : MCTargetStreamer(S) {}
-
----------------
Saleem Abdulrasool wrote:
> I dont see this being moved to the header, am I misunderstanding something or is there now a missing constructor?
It was moved to the ARMTargetStreamer.cpp file. I moved it there because I had to modify the constructor to create the data structure to hold the assembler constant pools .


http://llvm-reviews.chandlerc.com/D2638



More information about the llvm-commits mailing list