[llvm] r200138 - Implement the missing bits corresponding to .mips_hack_elf_flags.

Rafael EspĂ­ndola rafael.espindola at gmail.com
Tue Jan 28 08:54:16 PST 2014


On 28 January 2014 06:37, Matheus Almeida <Matheus.Almeida at imgtec.com> wrote:
> Hi Rafael,
>
> " Can't you use llvm-mc's mattr option to set it? For example, -mattr=n32 seems to correctly select the n32 abi."
> Yes, it appears to work.
>
> There's another issue related to the ELF header that I didn't mention on my previous e-mail but it can now be fixed/tested.
> EF_MIPS_32BITMODE should be set when the O32 ABI is used when targeting a Mips64 arch.
>
> The attached patch fixes the mentioned issues plus it adds more tests related to the different ABIs supported by Mips.

LGTM with just a nit:

+ # Default ABI for MIPS64 is N64

Please note in the test that this is a different default from gas.

Cheers,
Rafael



More information about the llvm-commits mailing list