Fwd: [llvm] r199149 - Factor the option and checking of compiler version better. Put the

[Carl-Anton Ingmarsson]

Hi!

> Modified: llvm/trunk/CMakeLists.txt
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/CMakeLists.txt?rev=199149&r1=199148&r2=199149&view=diff
> ==============================================================================
> --- llvm/trunk/CMakeLists.txt (original)
> +++ llvm/trunk/CMakeLists.txt Mon Jan 13 16:21:34 2014
> @@ -195,6 +195,9 @@ else()
>    option(LLVM_ENABLE_ASSERTIONS "Enable assertions" ON)
>  endif()
>
> +option(LLVM_FORCE_USE_OLD_HOST_TOOLCHAIN
> +       "Set to ON to force using an old, unsupported host toolchain." OFF)
> +

Was the change of option name done on purpose? (Adding HOST between OLD
and TOOLCHAIN)

> Modified: llvm/trunk/cmake/modules/HandleLLVMOptions.cmake
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/cmake/modules/HandleLLVMOptions.cmake?rev=199149&r1=199148&r2=199149&view=diff
> ==============================================================================
> --- llvm/trunk/cmake/modules/HandleLLVMOptions.cmake (original)
> +++ llvm/trunk/cmake/modules/HandleLLVMOptions.cmake Mon Jan 13 16:21:34 2014
> @@ -14,6 +14,22 @@ elseif( "${CMAKE_CXX_COMPILER_ID}" MATCH
>    set(LLVM_COMPILER_IS_GCC_COMPATIBLE ON)
>  endif()
>
> +if(NOT LLVM_FORCE_USE_OLD_TOOLCHAIN)

This doesn't match the new option name.

Best regards,
Carl-Anton