[PATCH] OS-independent __clear_cache for AARCH64

Tim Northover t.p.northover at gmail.com
Tue Jan 28 05:16:25 PST 2014


  Hi Joerg,

  Just one comment. As far as I can tell from the docs & remember the code itself is good.


================
Comment at: clear_cache.c:41
@@ -40,1 +40,3 @@
   sysarch(ARM_SYNC_ICACHE, &arg);
+#elif defined(__aarch64__)
+  uint64_t xstart = (uint64_t)(uintptr_t) start;
----------------
I strongly suspect we'll still want to forward onto the sys_icache_invalidate at Apple. But the routine looks good for Linux too, so I'd suggest "&& !defined(__APPLE__)".


http://llvm-reviews.chandlerc.com/D2631



More information about the llvm-commits mailing list