[Patch] Provide a stub implementation of PPCTargetMACHOStreamer

Iain Sandoe iain at codesourcery.com
Tue Jan 28 03:10:17 PST 2014


On 27 Jan 2014, at 22:02, Rafael EspĂ­ndola wrote:

> On 27 January 2014 16:30, Iain Sandoe <iain at codesourcery.com> wrote:

>> Here is a stub implementation, it's on the TODO to fill in the CPU* info from this.
>> cheers
> 
> +  virtual void emitTCEntry(const MCSymbol &S) {
> +    // Does nothing on Darwin, perhaps a diagnostic would be useful.
> +  }
> 
> is there a .tc directive at all for ppc macho? That is, will
> /usr/bin/as error on it? If so, the correct fix is probably to use a
> llvm_unreachable in here and make sure CodeGen doesn't use it when
> targeting MachO.

the system asm indeed errors on that directive, done the same for llvm.
> 
> LGTM with that fixed.

thanks for the review, r200309
Iain





More information about the llvm-commits mailing list