[patch] Fix pr14893

Rafael EspĂ­ndola rafael.espindola at gmail.com
Mon Jan 27 12:45:13 PST 2014


On 26 January 2014 23:24, Hal Finkel <hfinkel at anl.gov> wrote:
> ----- Original Message -----
>> From: "Rafael EspĂ­ndola" <rafael.espindola at gmail.com>
>> To: "Hal Finkel" <hfinkel at anl.gov>
>> Cc: "llvm-commits" <llvm-commits at cs.uiuc.edu>
>> Sent: Sunday, January 26, 2014 10:17:59 PM
>> Subject: Re: [patch] Fix pr14893
>>
>> > Passes are still responsible for dropping it. I agree, however,
>> > that we need more-convenient facilities for this.
>>
>> OK. Updated patch attached.
>
> +      // For an analogous reason, we must also drop all the metadata whose
> +      // semantic we don't know.
>
> I suggest:
> s/semantic we don't know/semantics we don't understand/
>
> Also, can we keep TBAA?

I think so. Updated patch attached. I also fixed the type Manman Ren noticed.

Cheers,
Rafael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: t.patch
Type: text/x-patch
Size: 525 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140127/a8470efb/attachment.bin>


More information about the llvm-commits mailing list