[patch] Fix pr14893

Hal Finkel hfinkel at anl.gov
Sun Jan 26 20:24:30 PST 2014


----- Original Message -----
> From: "Rafael EspĂ­ndola" <rafael.espindola at gmail.com>
> To: "Hal Finkel" <hfinkel at anl.gov>
> Cc: "llvm-commits" <llvm-commits at cs.uiuc.edu>
> Sent: Sunday, January 26, 2014 10:17:59 PM
> Subject: Re: [patch] Fix pr14893
> 
> > Passes are still responsible for dropping it. I agree, however,
> > that we need more-convenient facilities for this.
> 
> OK. Updated patch attached.

+      // For an analogous reason, we must also drop all the metadata whose
+      // semantic we don't know.

I suggest:
s/semantic we don't know/semantics we don't understand/

Also, can we keep TBAA?

 -Hal

> 
> Cheers,
> Rafael
> 

-- 
Hal Finkel
Assistant Computational Scientist
Leadership Computing Facility
Argonne National Laboratory




More information about the llvm-commits mailing list