[PATCH] PowerPC - Use MCInstrDesc to get instruction size

David Wiberg dwiberg at gmail.com
Sat Jan 25 16:03:29 PST 2014


2014-01-25 Hal Finkel <hfinkel at anl.gov>:
> David,
>
> LGTM, thanks! There is also PPCInstrInfo::GetInstSizeInBytes, which should also be fixed up. Would you mind taking care of that one too?

Thanks for the review. The attached patch adds the same kind of change
for GetInstSizeInBytes too. I do not have commit access.

/ David

>
>  -Hal
>
> ----- Original Message -----
>> From: "David Wiberg" <dwiberg at gmail.com>
>> To: "llvm-commits" <llvm-commits at cs.uiuc.edu>
>> Sent: Saturday, January 25, 2014 12:57:52 PM
>> Subject: [PATCH] PowerPC - Use MCInstrDesc to get instruction size
>>
>> Hello,
>>
>> The attached patch adds a reference to MCInstrInfo to the
>> PPCMCCodeEmitter and uses it to determine instruction size when
>> encoding instructions instead of using hard-coded values.
>>
>> / David
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>
> --
> Hal Finkel
> Assistant Computational Scientist
> Leadership Computing Facility
> Argonne National Laboratory
-------------- next part --------------
A non-text attachment was scrubbed...
Name: UseMCInstrDescForSize_2.patch
Type: application/octet-stream
Size: 2883 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140126/174c8d2d/attachment.obj>


More information about the llvm-commits mailing list