[llvm] r200034 - Add Constant Hoisting Pass

[Hans Wennborg]

On Fri, Jan 24, 2014 at 3:11 PM, Hans Wennborg <hans at chromium.org> wrote:
> Hi juergen,
>
> On Fri, Jan 24, 2014 at 12:18 PM, Juergen Ributzka <juergen at apple.com> wrote:
>> Author: ributzka
>> Date: Fri Jan 24 14:18:00 2014
>> New Revision: 200034
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=200034&view=rev
>> Log:
>> Add Constant Hoisting Pass
>
> This is causing some warnings (from
> http://lab.llvm.org:8011/builders/llvm-x86_64-ubuntu/builds/13321/steps/compile/logs/warnings%20%284%29):
>
> /home/jabbey/src/osuosl/buildbot/sandbox/llvm-x86_64-ubuntu/llvm-x86_64-ubuntu/llvm/include/llvm/Analysis/TargetTransformInfo.h:306:20:
> warning: ‘virtual unsigned int
> llvm::TargetTransformInfo::getIntImmCost(unsigned int, const
> llvm::APInt&, llvm::Type*) const’ was hidden [-Woverloaded-virtual]
> ARMTargetTransformInfo.cpp:81:3: warning:   by ‘virtual unsigned int
> {anonymous}::ARMTTI::getIntImmCost(const llvm::APInt&, llvm::Type*)
> const’ [-Woverloaded-virtual]
> /home/jabbey/src/osuosl/buildbot/sandbox/llvm-x86_64-ubuntu/llvm-x86_64-ubuntu/llvm/include/llvm/Analysis/TargetTransformInfo.h:308:20:
> warning: ‘virtual unsigned int
> llvm::TargetTransformInfo::getIntImmCost(llvm::Intrinsic::ID, const
> llvm::APInt&, llvm::Type*) const’ was hidden [-Woverloaded-virtual]
> ARMTargetTransformInfo.cpp:81:3: warning:   by ‘virtual unsigned int
> {anonymous}::ARMTTI::getIntImmCost(const llvm::APInt&, llvm::Type*)
> const’ [-Woverloaded-virtual]
>
> The warning looks valid. Can you take a look?

I've reverted the patch in r200058. If you think that's wrong, feel
free to re-apply it, but it seems weird to me that we're adding two
new getIntImmCost overloads, and not overriding them in the non-X86
targets.

Thanks,
Hans