[compiler-rt] r200035 - Don't use .arm for ARMv7M, which will use the hwdiv path. Non-hwdiv

Michael Ilseman milseman at apple.com
Fri Jan 24 13:06:13 PST 2014


On Jan 24, 2014, at 12:45 PM, Joerg Sonnenberger <joerg at bec.de> wrote:

> Author: joerg
> Date: Fri Jan 24 14:45:18 2014
> New Revision: 200035
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=200035&view=rev
> Log:
> Don't use .arm for ARMv7M, which will use the hwdiv path. Non-hwdiv
> remains ARM mode only, supporting thumb requires explicit it prefixes
> for the predicted adds/subs and adjusting the offset computation for the
> different block sizes.
> 
> Modified:
>    compiler-rt/trunk/lib/arm/udivmodsi4.S
>    compiler-rt/trunk/lib/arm/udivsi3.S
>    compiler-rt/trunk/lib/arm/umodsi3.S
> 
> Modified: compiler-rt/trunk/lib/arm/udivmodsi4.S
> URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/arm/udivmodsi4.S?rev=200035&r1=200034&r2=200035&view=diff
> ==============================================================================
> --- compiler-rt/trunk/lib/arm/udivmodsi4.S (original)
> +++ compiler-rt/trunk/lib/arm/udivmodsi4.S Fri Jan 24 14:45:18 2014
> @@ -23,7 +23,9 @@
> #endif
> 
>  	.text
> +#if !__ARM_ARCH_EXT_IDIV__
>  	.arm
> +#endi

I think you missed an “f” at the end of “endi"

> 	.p2align 2
> DEFINE_COMPILERRT_FUNCTION(__udivmodsi4)
> #if __ARM_ARCH_EXT_IDIV__
> 
> Modified: compiler-rt/trunk/lib/arm/udivsi3.S
> URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/arm/udivsi3.S?rev=200035&r1=200034&r2=200035&view=diff
> ==============================================================================
> --- compiler-rt/trunk/lib/arm/udivsi3.S (original)
> +++ compiler-rt/trunk/lib/arm/udivsi3.S Fri Jan 24 14:45:18 2014
> @@ -25,7 +25,9 @@
> #endif
> 
> 	.text
> +#if !__ARM_ARCH_EXT_IDIV__
> 	.arm
> +#endif
> 	.p2align 2
> DEFINE_AEABI_FUNCTION_ALIAS(__aeabi_uidiv, __udivsi3)
> DEFINE_COMPILERRT_FUNCTION(__udivsi3)
> 
> Modified: compiler-rt/trunk/lib/arm/umodsi3.S
> URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/arm/umodsi3.S?rev=200035&r1=200034&r2=200035&view=diff
> ==============================================================================
> --- compiler-rt/trunk/lib/arm/umodsi3.S (original)
> +++ compiler-rt/trunk/lib/arm/umodsi3.S Fri Jan 24 14:45:18 2014
> @@ -25,7 +25,9 @@
> #endif
> 
> 	.text
> +#if !__ARM_ARCH_EXT_IDIV__
> 	.arm
> +#endif
> 	.p2align 2
> DEFINE_COMPILERRT_FUNCTION(__umodsi3)
> #if __ARM_ARCH_EXT_IDIV__
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits





More information about the llvm-commits mailing list