[PATCH] Improved udivmodsi4 with support for ARMv4

Renato Golin renato.golin at linaro.org
Thu Jan 23 13:50:11 PST 2014



================
Comment at: lib/assembly.h:60
@@ +59,3 @@
+# ifndef __ARM_ARCH
+#  if defined (__ARM_ARCH_5T__) || defined (__ARM_ARCH_5__) \
+      defined (__ARM_ARCH_5TE__) || defined (__ARM_ARCH_5TEJ__)
----------------
Missing an || here

================
Comment at: lib/arm/umodsi3.S:150
@@ +149,2 @@
+
+END_COMPILERRT_FUNCTION(__umodsi3)
----------------
I remember this vaguely, but now it doesn't compile. Looks like a left over of something?


http://llvm-reviews.chandlerc.com/D2595



More information about the llvm-commits mailing list