[llvm-commits] [PATCH] Remove tail marker when changing an argument to an alloca.

Rafael EspĂ­ndola rafael.espindola at gmail.com
Thu Jan 23 09:27:11 PST 2014


> LGTM. Good catch!

Thanks. Committed as r199909.

> Sidenote: I assume that doing this transform is more important than leaving
> the call as a tail call? I think so, but I'm not sure. Otherwise, we ought
> to block this transform when we see the argument being used by a tail call.

I am pretty sure it is profitable in the current infrastructure: We do
a pretty horrible job with byval arguments. There is a copy in the
caller and one in the stack frame. With this transformation we get
only one copy (in the callee).

> Nick

Cheers,
Rafael



More information about the llvm-commits mailing list